-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: v2+ Go modules release #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applejag
added
the
rfc
This issue or pull requests contains a new Request For Comments
label
Dec 13, 2021
applejag
requested review from
Alexamakans,
fredx30,
Grimwind,
iverestefans and
Pikabanga
December 13, 2021 12:27
This was referenced Dec 13, 2021
Alexamakans
approved these changes
Jan 3, 2022
Pikabanga
suggested changes
Jan 11, 2022
Co-authored-by: Mikael Berrin <pikabanga@gmail.com>
Pikabanga
approved these changes
Jan 11, 2022
This was referenced Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go modules, which is the package management strategy we use in Wharf, has
strict rules on how to publish v2+ releases. We have not been Go-modules
compliant in some of our repositories. This RFC suggest one of the many
alternative solutions for being compliant, with its up- and downsides.
This is an important decision, as it induces a lot of headaches if we do it
wrong and have to switch to a different strategy later on.
This is based on a conversation that popped up in a PR comment thread:
iver-wharf/wharf-api-client-go#29 (comment)
Rendered
Link to the markdown file here on GitHub. Example:
https://github.com/iver-wharf/rfcs/blob/rfc/go-modules/_published/0026-v2-go-modules-release.md