Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new error response functions #17

Merged
merged 7 commits into from
Jul 12, 2021
Merged

Added new error response functions #17

merged 7 commits into from
Jul 12, 2021

Conversation

Alexamakans
Copy link
Member

@Alexamakans Alexamakans added the enhancement New feature or request label Jul 7, 2021
@Alexamakans Alexamakans self-assigned this Jul 7, 2021
@Alexamakans Alexamakans added this to In progress in Backlog via automation Jul 7, 2021
@Alexamakans Alexamakans changed the title Add new error response functions Added new error response functions Jul 7, 2021
applejag
applejag suggested changes Jul 7, 2021
View reviewed changes
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
Backlog automation moved this from In progress to Review in progress Jul 7, 2021
Alexamakans and others added 2 commits July 8, 2021 09:55
@Alexamakans @applejag
Apply suggestions from code review
3aa4b5a 
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
@Alexamakans
Added WriteUnauthorized function
0741df5
This was referenced Jul 8, 2021
Merged
Merged
Merged
@Alexamakans Alexamakans requested a review from applejag July 8, 2021 11:41
applejag
applejag approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Don't forget to also add these to the docs repo :)

fredx30
fredx30 approved these changes Jul 12, 2021
View reviewed changes
pkg/ginutil/writeproblem.go Outdated Show resolved Hide resolved
Backlog automation moved this from Review in progress to Reviewer approved Jul 12, 2021
@Alexamakans @fredx30
Apply suggestions from code review
46aad52 
Co-authored-by: Fredrik <fdyrvold@outlook.com>
@Alexamakans Alexamakans mentioned this pull request Jul 12, 2021
Merged
@Alexamakans Alexamakans merged commit a4ed122 into master Jul 12, 2021
Backlog automation moved this from Reviewer approved to Done Jul 12, 2021
@Alexamakans Alexamakans deleted the feature/add-new-error-response-functions branch July 12, 2021 11:44
@applejag applejag mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@applejag applejag applejag approved these changes

@fredx30 fredx30 fredx30 approved these changes

Assignees

@Alexamakans Alexamakans

Labels
enhancement New feature or request
Projects
No open projects
Backlog
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alexamakans @applejag @fredx30