Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked error output to send IETF RFC-7807 compatible problem responses #15

Merged
merged 13 commits into from
Jul 19, 2021

Conversation

Alexamakans
Copy link
Member

@Alexamakans Alexamakans commented Jun 15, 2021

Closes #14
Depends on iver-wharf/wharf-core#17

Copy link
Contributor

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrote a lot of suggestions over at iver-wharf/wharf-provider-azuredevops#14

Instead of repeating myself I suggest looking at those comments to use as template for this one

@Alexamakans Alexamakans changed the title Changed to use wharf-core/pkg/ginutil Reworked error output to send IETF RFC-7807 compatible problem responses Jun 21, 2021
@Alexamakans Alexamakans marked this pull request as ready for review July 15, 2021 11:00
CHANGELOG.md Outdated Show resolved Hide resolved
import.go Outdated Show resolved Hide resolved
import.go Outdated Show resolved Hide resolved
Alexamakans and others added 3 commits July 17, 2021 16:05
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
…f/wharf-provider-gitlab into feature/use-wharf-core-ginutil
Copy link
Contributor

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits. Otherwise: LGTM!

import.go Outdated Show resolved Hide resolved
import.go Outdated Show resolved Hide resolved
import.go Outdated Show resolved Hide resolved
import.go Outdated Show resolved Hide resolved
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
@Alexamakans Alexamakans merged commit 39a969c into master Jul 19, 2021
@Alexamakans Alexamakans deleted the feature/use-wharf-core-ginutil branch July 19, 2021 09:52
@applejag applejag mentioned this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use wharf-core pkg/ginutil for error responses
3 participants