-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config #4
Config #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its clearly marked config which is good. Im not sure what the config is for though even after having skimmed though the source once.
Configuring Wharf. So for each component (wharf-provider-github, wharf-api, etc) they will use this library so they can be configured. Currently you can only configure Wharf via environment variables, which is very tedious once the configs options grow in numbers, which has started to happen in the wharf-api component. Lettings users configure through files is just another means of configuring. They stack up and merge together, so if you define When working in Kubernetes, it's often better to work with ConfigMaps than environment variables as it can support hot-reloading if the application itself supports it. This implementation does not support watching the config files for changes, but that's something we could add later. |
Related to #1, and based on iver-wharf/rfcs#4