Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config #4

Merged
merged 13 commits into from
May 26, 2021
Merged

Config #4

merged 13 commits into from
May 26, 2021

Conversation

applejag
Copy link
Contributor


Related to #1, and based on iver-wharf/rfcs#4

@applejag applejag added the enhancement New feature or request label May 21, 2021
@applejag applejag self-assigned this May 21, 2021
@applejag applejag added this to In progress in Backlog via automation May 21, 2021
@applejag applejag mentioned this pull request May 21, 2021
3 tasks
Copy link

@iverestefans iverestefans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Great job!

Copy link
Contributor

@fredx30 fredx30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its clearly marked config which is good. Im not sure what the config is for though even after having skimmed though the source once.

@applejag
Copy link
Contributor Author

Its clearly marked config which is good. Im not sure what the config is for though even after having skimmed though the source once.

Configuring Wharf. So for each component (wharf-provider-github, wharf-api, etc) they will use this library so they can be configured. Currently you can only configure Wharf via environment variables, which is very tedious once the configs options grow in numbers, which has started to happen in the wharf-api component.

Lettings users configure through files is just another means of configuring. They stack up and merge together, so if you define A=foo and B=bar in the config file and then set the A=moo in environment variables then the component will read the configs as solely A=moo and B=bar

When working in Kubernetes, it's often better to work with ConfigMaps than environment variables as it can support hot-reloading if the application itself supports it. This implementation does not support watching the config files for changes, but that's something we could add later.

Backlog automation moved this from In progress to Reviewer approved May 26, 2021
@applejag applejag merged commit 81b7977 into master May 26, 2021
Backlog automation moved this from Reviewer approved to Done May 26, 2021
@applejag applejag deleted the feature/config branch May 26, 2021 08:54
@applejag applejag mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants