Added pkg/app/version.go and examples, changelog, and go.mod #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2021
Merged
Closed
fredx30
approved these changes
May 24, 2021
Pikabanga
approved these changes
May 26, 2021
This was referenced May 28, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You see in the pkg/app/example_version_gin_endpoint_test.go file how I propose we do the version implementation from now on. As compared to how it's proposed in iver-wharf/wharf-provider-github#5
The suggested implementation in the example is that the
pkg/ginutilsis not needed. This core lib repo only references gin-gonic in the example tests, and leaves the rest for the user of this library. The core is like only 5 lines in total so I thought it was better, and letting them define the version endpoint themselves will leave less confusion to where theGET /versionendpoint comes from, as well as more control in case you need it.Related to #1, and based on iver-wharf/rfcs#4