Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added version endpoint #5

Merged
merged 2 commits into from
May 31, 2021
Merged

Added version endpoint #5

merged 2 commits into from
May 31, 2021

Conversation

applejag
Copy link
Contributor

@applejag applejag commented May 11, 2021 •
edited
Loading

  • Added version.go with GET /import/github/version endpoint
  • Added deploy/update-version.sh to update version.yaml on Docker build
  • Updated main.go with metadata
  • Updated .wharf-ci.yml to populate BUILD_* build args
  • Updated CHANGELOG.md
  • Updated swag init docs & usage as we're now relying on types from foreign packages (app.Version)

Based on iver-wharf/wharf-core#2

Screenshot_2021-05-28_16-05-24

Closes #6

@applejag applejag added the enhancement New feature or request label May 11, 2021
@applejag applejag self-assigned this May 11, 2021
@applejag applejag added this to In progress in Backlog via automation May 11, 2021
@applejag applejag force-pushed the feature/version-endpoint branch 2 times, most recently from 3831862 to 6d9bfb7 Compare May 11, 2021 14:07
@applejag applejag moved this from In progress to Review in progress in Backlog May 11, 2021
@applejag applejag mentioned this pull request May 11, 2021
Merged
@applejag applejag force-pushed the feature/version-endpoint branch 2 times, most recently from 92b85aa to a811972 Compare May 11, 2021 14:36
Pikabanga
Pikabanga suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@Pikabanga Pikabanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of doing search replace in the files that will be compiled. Consider using environment variables or a config file that the code instead reads to build the Version struct.

Dockerfile Show resolved Hide resolved
deploy/update-version.sh Show resolved Hide resolved
@applejag applejag marked this pull request as draft May 12, 2021 09:28
@applejag applejag mentioned this pull request May 20, 2021
Merged
@applejag applejag force-pushed the feature/version-endpoint branch 2 times, most recently from f367fef to ab0d164 Compare May 28, 2021 13:59
@applejag applejag marked this pull request as ready for review May 28, 2021 14:02
@applejag applejag requested a review from Pikabanga May 28, 2021 14:03
@applejag
Copy link
Contributor Author

applejag commented May 28, 2021 •
edited
Loading

@Pikabanga
I'm not a fan of doing search replace in the files that will be compiled. Consider using environment variables or a config file that the code instead reads to build the Version struct.

I'm quite happy that I found this: https://golang.org/pkg/embed/

fredx30
fredx30 approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@fredx30 fredx30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Backlog automation moved this from Review in progress to Reviewer approved May 31, 2021
@applejag applejag merged commit dd263a8 into master May 31, 2021
Backlog automation moved this from Reviewer approved to Done May 31, 2021
@applejag applejag deleted the feature/version-endpoint branch May 31, 2021 08:31
@applejag applejag mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredx30 fredx30 fredx30 approved these changes

@Pikabanga Pikabanga Pikabanga approved these changes

@iverestefans iverestefans Awaiting requested review from iverestefans

Assignees

@applejag applejag

Labels
enhancement New feature or request
Projects
No open projects
Backlog
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version endpoint
3 participants
@applejag @fredx30 @Pikabanga