Skip to content

Commit

Permalink
disable noise gate processor (#48)
Browse files Browse the repository at this point in the history
* disable noise gate processor

* fix lint
  • Loading branch information
LancharroDav committed May 7, 2021
1 parent fae7e20 commit 2b2bbaa
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.1.19] - 2021-05-07
### Added
- Disable NoiseGateProcessor due to inconsistency when more than 3 people in a meeting.

## [1.1.18] - 2021-05-05
### Added
- Re-adjust Noise Gate threshold.
Expand Down
8 changes: 5 additions & 3 deletions react/features/filmstrip/components/web/Thumbnail.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import { ConnectionIndicator } from '../../../connection-indicator';
import { DisplayName } from '../../../display-name';
import { StatusIndicators, RaisedHandIndicator, DominantSpeakerIndicator } from '../../../filmstrip';
import { PresenceLabel } from '../../../presence-status';
import { createNoiseGateProcessor } from '../../../stream-effects/noisegate';
import { getCurrentLayout, LAYOUTS } from '../../../video-layout';
import { LocalVideoMenuTriggerButton, RemoteVideoMenuTriggerButton } from '../../../video-menu';
import {
Expand All @@ -39,6 +38,8 @@ import {
import { isVideoPlayable, computeDisplayMode } from '../../functions';
import logger from '../../logger';

// import { createNoiseGateProcessor } from '../../../stream-effects/noisegate';

const JitsiTrackEvents = JitsiMeetJS.events.track;

declare var interfaceConfig: Object;
Expand Down Expand Up @@ -805,7 +806,8 @@ class Thumbnail extends Component<Props, State> {
} = this.props;
const { id } = _participant;
const { audioLevel, canPlayEventReceived, volume } = this.state;
const newVolume = createNoiseGateProcessor(audioLevel);

// const newVolume = createNoiseGateProcessor(audioLevel);
const styles = this._getStyles();
const containerClassName = this._getContainerClassName();

Expand Down Expand Up @@ -851,7 +853,7 @@ class Thumbnail extends Component<Props, State> {
id = { `remoteAudio_${audioTrackId || ''}` }
muted = { _startSilent }
onInitialVolumeSet = { this._onInitialVolumeSet }
volume = { newVolume } />
volume = { volume } />
}
<div className = 'videocontainer__background' />
<div className = 'videocontainer__toptoolbar'>
Expand Down

0 comments on commit 2b2bbaa

Please sign in to comment.