fix Slider not emit on-change event when click bar at first time #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pr, could you provide an example of this bug by https://jsfiddle.net/yyrzhm46/ ? |
icarusion
changed the title
SergioCrisostomo
suggested changes
Apr 3, 2018
There was a problem hiding this comment.
@miomio-xiao thank you for for finding this bug and suggesting a fix 👍 I think this was a bug I made, sorry!
I think this should be fixed in line 154, with oldValue: [...val],, and no other changes are needed. That is the origin of the problem.
If you could test that and update the PR would be great!
|
@SergioCrisostomo Thanks for the suggestion, it has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oldValue与currentValue初始化指向相同，直接改变currentValue导致oldValue的值也发生变化。