Merge queue arguments properly with retry_queue flag #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jKatt
force-pushed
the
fix-retry-options-merging
branch
from
ad6ce3f
to
5902b07
Compare
brerx
approved these changes
Feb 28, 2023
|
Can you please update the gem version? I think 0.9.1 is ok. |
|
The authors in the gemspec also need some adjustments. |
brerx
approved these changes
Feb 28, 2023
johannesluedke
approved these changes
Feb 28, 2023
We should do that when we tackle the automatic publishing I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging the queue options we have previously overwritten the given arguments.
This PR fixes this behavior by also merging the nested arguments hash of the given options.