Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nanquantile #21359

Closed
wants to merge 2 commits into from
Closed

added nanquantile #21359

wants to merge 2 commits into from

Conversation

arham-kk
Copy link
Contributor

@arham-kk arham-kk commented Aug 6, 2023

close #20890

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on master, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 6, 2023
@arham-kk
Copy link
Contributor Author

arham-kk commented Aug 6, 2023

Hi @DecFox can you please review this PR,
Thanks.

@KareemMAX
Copy link
Contributor

Hey @arham-kk,

Sadly this PR is linked to an issue you didn't author, and an implementation for it has already been merged #20888

It seems like you didn't follow our contribution guide (which is a bit hard I admit), but you need to first find a frontend function that are not references by issues. As an issue with a function name is considered to be claimed by the issue author. A great resource for contributing is our contribution guide, specifically ToDo list issues.

I'm sorry that I have to close your PR, please take care of these instructions next time.

And thank you so much for contributing to Ivy 🚀

@KareemMAX KareemMAX closed this Aug 7, 2023
@arham-kk arham-kk deleted the nanquantile branch August 7, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nanquantile
4 participants