fix: fixed frontend function torch.mean for all backends
#28568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
PyTorch Frontend
Ishticode
suggested changes
Mar 14, 2024
| @@ -480,6 +480,7 @@ def test_torch_mean( | |||
| backend_fw, | |||
| ): | |||
| input_dtype, x, axis, *_ = dtype_and_x | |||
| assume("float" in input_dtype[0] or "complex" in input_dtype[0]) | |||
There was a problem hiding this comment.
why does it need to assume this when the dtypes are already specified to be float_and_complex?
ideally we shouldn't need filtering etc. any dtypes in test but rather on the functions with un/supporteded_dtype decorators.
There was a problem hiding this comment.
Sorry my bad. I've made the corrections.
Fixed data type conversion occuring due to incorrect input_dtype supplied to test_frontend_function. Added `@with_supported_dtypes` to frontend function `torch.mean`.
ZenithFlux
force-pushed
the
chaitanya/fixing_test_torch_mean
branch
from
d72ed38
to
85773ed
Compare
Ishticode
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Thank @ZenithFlux
failures seem unrelated.
Thank you very much :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
@with_supported_dtypesto frontend functiontorch.mean.Related Issue
Closes #28563
Closes #28564
Closes #28565
Closes #28566
Checklist