Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: jax, torch, paddle and tensorflow - creation.paddle.tril #28596

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 14, 2024

PR Description

Changed to supported dtypes according to the function definition and docs.

Related Issue

Close #28577
Close #28576
Close #28575
Close #28574

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Mar 14, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this one bool also works
as seen in
Screenshot from 2024-03-16 10-09-38
so we should try to support it in our frontend
Rest is good @ZJay07

@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 16, 2024

@Ishticode Oh, seems like I already added bool inside the supported dtypes decorator

@ZJay07 ZJay07 requested a review from Ishticode March 16, 2024 10:46
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZJay07
My bad. i only noticed the removal. Yes it is listed under the supported types. Thank you for pointing out. :)

@Ishticode Ishticode merged commit aec6e1d into ivy-llc:main Mar 16, 2024
269 of 289 checks passed
@ZJay07 ZJay07 deleted the fixing-test-7 branch March 26, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
3 participants