Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torch frontend tensor functions #4981

Merged
merged 6 commits into from
Sep 30, 2022
Merged

torch frontend tensor functions #4981

merged 6 commits into from
Sep 30, 2022

Conversation

AnnaTz
Copy link
Contributor

@AnnaTz AnnaTz commented Sep 27, 2022

No description provided.

@AnnaTz
Copy link
Contributor Author

AnnaTz commented Sep 27, 2022

Close #4976

@AnnaTz
Copy link
Contributor Author

AnnaTz commented Sep 27, 2022

Close #4975

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 27, 2022
@AnnaTz
Copy link
Contributor Author

AnnaTz commented Sep 27, 2022

Close #4977

simonetgordon
simonetgordon reviewed Sep 27, 2022
View reviewed changes
ivy/functional/frontends/torch/tensor_functions.py Outdated
@@ -2,10 +2,6 @@
import ivy


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'm surprised I didn't notice that. Thanks, I recovered it.

@simonetgordon
Copy link
Contributor

Hi @AnnaTz, is_non_zero is passing - nice! But numel and is_floating_point are failing. Check Details -> Run Frontend Tests then search for these functions in the error output. You will be able to see the error stacktraces. You should be able to reproduce the errors by testing locally. Let me know if you need any help!

@AnnaTz
Copy link
Contributor Author

AnnaTz commented Sep 28, 2022

Hi @AnnaTz, is_non_zero is passing - nice! But numel and is_floating_point are failing. Check Details -> Run Frontend Tests then search for these functions in the error output. You will be able to see the error stacktraces. You should be able to reproduce the errors by testing locally. Let me know if you need any help!

It's strange, but sometimes tests pass locally and yet fail in the workflows.

@simonetgordon
Copy link
Contributor

Hi @AnnaTz, is_non_zero is passing - nice! But numel and is_floating_point are failing. Check Details -> Run Frontend Tests then search for these functions in the error output. You will be able to see the error stacktraces. You should be able to reproduce the errors by testing locally. Let me know if you need any help!

It's strange, but sometimes tests pass locally and yet fail in the workflows.

Yes, this is actually to be expected due to the random nature of hypothesis testing, which you can read about here.

simonetgordon
simonetgordon approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@simonetgordon simonetgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@AnnaTz AnnaTz merged commit 8a918e8 into ivy-llc:master Sep 30, 2022
@AnnaTz AnnaTz deleted the torch_tensor_functions branch December 1, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonetgordon simonetgordon simonetgordon approved these changes

Assignees

@simonetgordon simonetgordon

Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AnnaTz @simonetgordon @ivy-leaves