[BUG] Poco array fields are null #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructorBuilder.cs` file and modifications to the `CsPlainSourceBuilder.cs` file. The new file contains the `CsPlainConstructorBuilder` class, which is used to build constructors for classes. The `CsPlainSourceBuilder.cs` file was updated to use this new class, specifically the `Create` method, to add constructors to the source code. Additionally, the `Arrays.cs` file was updated with a new method for creating and initializing arrays, and the `PlainersSwappingTests.cs` file had code for initializing an array commented out. Changes: 1. Addition of `CsPlainConstructorBuilder.cs` file: This new file contains the `CsPlainConstructorBuilder` class, which is used to build constructors for classes. It implements the `ICombinedThreeVisitor` interface and contains methods for creating different types of declarations and adding them to the source code. It also contains a `Create` method which is used to create a new instance of the `CsPlainConstructorBuilder` class and add the constructor to the source code. 2. Modification of `CsPlainSourceBuilder.cs` file: The `using AXSharp.Compiler.Cs.Onliner;` directive was added to allow the `CsPlainSourceBuilder` class to use the `CsPlainConstructorBuilder` class. The `CsPlainConstructorBuilder.Create` method was added to the `CreateClassDeclaration` method, creating a new instance of the `CsPlainConstructorBuilder` class and adding the constructor to the source code. 3. Addition of `InstantiateArray` method in `Arrays.cs` file: This new method is used to create a new array and initialize it with a specified initializer function and array bounds. 4. Commenting out of array initialization in `PlainersSwappingTests.cs` file: The code for initializing the `ArrayOfDrives` array was commented out, suggesting that the array is now being initialized elsewhere, possibly in the constructor of the `p` object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now initialize complex arrays in the poco object to prevent null ref. cxception when the POCO object is not fully initialized.
Changes:
Addition of
CsPlainConstructorBuilder.csfile: This new file contains theCsPlainConstructorBuilderclass, which is used to build constructors for classes. It implements theICombinedThreeVisitorinterface and contains methods for creating different types of declarations and adding them to the source code. It also contains aCreatemethod which is used to create a new instance of theCsPlainConstructorBuilderclass and add the constructor to the source code.Modification of
CsPlainSourceBuilder.csfile: Theusing AXSharp.Compiler.Cs.Onliner;directive was added to allow theCsPlainSourceBuilderclass to use theCsPlainConstructorBuilderclass. TheCsPlainConstructorBuilder.Createmethod was added to theCreateClassDeclarationmethod, creating a new instance of theCsPlainConstructorBuilderclass and adding the constructor to the source code.Addition of
InstantiateArraymethod inArrays.csfile: This new method is used to create a new array and initialize it with a specified initializer function and array bounds.Commenting out of array initialization in
PlainersSwappingTests.csfile: The code for initializing theArrayOfDrivesarray was commented out, suggesting that the array is now being initialized elsewhere, possibly in the constructor of thepobject.closes #311