Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python to 3.8 #232

Merged
merged 15 commits into from
Jun 7, 2021
Merged

Upgrade python to 3.8 #232

merged 15 commits into from
Jun 7, 2021

Conversation

fulder
Copy link
Contributor

@fulder fulder commented May 31, 2021

Upgrade plugins (with no opened PRs) from old python 3.7 version to 3.8 and add the python3 packages for easier plugin maintenance (where python3 binaries can be used instead of upgrading them for every minor python release)

Closes: #230


Thank you for your submission to the FreeNAS community plugins repository!

Please ensure the following guidelines are met when submitting a new Plugin.

  1. Add the entry to INDEX in alphabetical order
  2. Includes a new icon in the ./icon/ directory
  3. Ensure the submitted icon file is a valid PNG that is 128x128 in size
  4. Add new plugin cirrus task

homeassistant.json Outdated Show resolved Hide resolved
Copy link
Member

@sonicaj sonicaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fulder can you please confirm if we are not regressing for esphome ?

@fulder
Copy link
Contributor Author

fulder commented Jun 7, 2021

@sonicaj, from my understanding esphome should be ready for this change. The current cirrus task is failing due to the plugin being hardcoded to the python3.7 version. Once this is merge, the plugin PR here should be merged as well: tprelog/iocage-esphome#7 or is there something I've missed regarding this plugin (like Home Assistant) @tprelog (I'm guessing it is fine because of your comment in the PR, just doublechecking 😺 ) ?

Copy link
Member

@sonicaj sonicaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying @fulder, let's wait for @tprelog to confirm/merge and we can merge this asap as well then :)

@tprelog
Copy link
Contributor

tprelog commented Jun 7, 2021

@sonicaj - Let's go ahead and merge this.

I can merge @fulders pull request in the ESPHome repo as well

@sonicaj sonicaj merged commit a79435d into ix-plugin-hub:master Jun 7, 2021
@sonicaj
Copy link
Member

sonicaj commented Jun 7, 2021

Awesome, thank you @tprelog for confirming

@tprelog
Copy link
Contributor

tprelog commented Jun 7, 2021

I just merged @fulder pull request on my end for ESPHome

@fulder
Copy link
Contributor Author

fulder commented Jun 7, 2021

Thanks for the merges! :)

@fulder fulder deleted the python-bump branch June 10, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh Plugin of Bazarr fails on install
3 participants