fix: trailing slashes and links #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navbar /post --> /post/ Added .history (vscode extension) folder ignored Fix broken link to /postX/sixth-post Fix Broken sisth-post Npm Caniuse-lite update (browserlist) Requested by: zzikkzzakk
ixartz
reviewed
Jun 10, 2023
src/pages/posts/sixth-post.md
Outdated
| @@ -118,7 +118,7 @@ Some text to show that the reference links can follow later. | |||
| Images included in _\_posts_ folder are lazy loaded. | |||
|
|
|||
| Inline-style: | |||
|  | |||
|  | |||
There was a problem hiding this comment.
I think http://localhost:3000 should be removed. Otherwise, everything else looks good to me.
There was a problem hiding this comment.
We could point to the repos url instead what you think ?
If you just remove the domain the page won't load and thus break the app
There was a problem hiding this comment.
@Izocel, we should just remove the domain. If we remove the domain and if the image won't load, this mean there is a bug.
Putting localhost:3000 is not a solution because it will break in production with a real domain.
|
@Izocel Thank you for making the change and taking the time to create the PR. I just merge it. |
|
My pleasure i'll check others issues when I have loose time you can also tag me if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navbar /post --> /post/
Added .history (vscode extension) folder ignored
Fix broken link to /postX/sixth-post
Fix Broken sisth-post
Npm Caniuse-lite update (browserlist)
Requested by: zzikkzzakk