Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reddit #1

Merged
merged 15 commits into from
Feb 25, 2021
Merged

Feature/reddit #1

merged 15 commits into from
Feb 25, 2021

Conversation

ixboy
Copy link
Owner

@ixboy ixboy commented Feb 24, 2021

Hello, this is our Micro-reddit project we have created it as requested, please do review our work and tell us if we can merge.

Thank you!

Copy link

@whiz25 whiz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid PR 😞

Hey guys. I really appreciate the efforts put into this PR. The project is well setup but I am marking this PR as invalid because you don't have linters setup as required.

Checkout this repo for instructions on how to setup linters with Github actions.

Martin Afani

@ixboy
Copy link
Owner Author

ixboy commented Feb 25, 2021

Hello, we really appreciate your feedback and it has helped us a lot, however, we have fixed the linter setup as required please do review our work and tell us if we can merge.

Thank you!

@mimipeshy
Copy link

STATUS: CHANGES REQUIRED 🔴 ♻️

Hello, team @ixboy and @whiz25 👋🏾 👋🏾 , great job you have done in this milestone, bravo 💪🏾 . However, before the project can be marked as complete the following have to be worked on

  • Update your README file 😄
  • Since this project is terminal-based, don't forget to add screenshots/commands on how to run your project.

That's all 😄 kindly submit another review when done.

Feel free to reach out to me on slack if you have any questions or something is unclear, or just comment on this PR and tag my name and I will be glad to help
Regards
Peris Ndanu

@Nasa28
Copy link
Collaborator

Nasa28 commented Feb 25, 2021

STATUS: CHANGES REQUIRED

Hello, team @ixboy and @whiz25 👋🏾 👋🏾 , great job you have done in this milestone, bravo 💪🏾 . However, before the project can be marked as complete the following have to be worked on

  • Update your README file smile
  • Since this project is terminal-based, don't forget to add screenshots/commands on how to run your project.

That's all kindly submit another review when done.

Feel free to reach out to me on slack if you have any questions or something is unclear, or just comment on this PR and tag my name and I will be glad to help
Regards
Peris Ndanu

@Nasa28 Nasa28 closed this Feb 25, 2021
@Nasa28 Nasa28 reopened this Feb 25, 2021
@Nasa28
Copy link
Collaborator

Nasa28 commented Feb 25, 2021

STATUS: CHANGES REQUIRED

Hello, team @ixboy and @whiz25 👋🏾 👋🏾 , great job you have done in this milestone, bravo 💪🏾 . However, before the project can be marked as complete the following have to be worked on

  • Update your README file smile
  • Since this project is terminal-based, don't forget to add screenshots/commands on how to run your project.

That's all kindly submit another review when done.
Feel free to reach out to me on slack if you have any questions or something is unclear, or just comment on this PR and tag my name and I will be glad to help
Regards
Peris Ndanu

Thank you for your feedback. We have updated the readme file as requested. Kindly review our work so that we can proceed to the next project.

Copy link

@lekegitrepo lekegitrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved ✔️

Good job @ixboy and @Nasa28 💯 💯

This project is approved ✅

Reviewed by Temitayo Adeleke

@ixboy ixboy merged commit f083e0c into development Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants