Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reading XRECORD objects with no duplicate-handling flag #62

Merged
merged 1 commit into from
May 26, 2016

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented May 26, 2016

When reading and XRECORD object, the only possibilities following the 100/AcDbXrecord code pair are either a code 280 which indicates the duplicate record handling flag, or a code 102 which is just regular data.

This moves the code 280 handler higher in the loop to account for the case where a code 102 immediately follows the 100/AcDbXrecord pair which means any subsequent code 280 must belong to the data section and not the duplicate record handling flag.

Fixes #61

FYI @AleksandarDev

@brettfo
Copy link
Member Author

brettfo commented May 26, 2016

Note: the full fix for reading XRECORD objects comes from an earlier commit (b42cba2) as well as this PR to correct the code 280 handling.

@brettfo brettfo merged commit f6edd3c into master May 26, 2016
@brettfo brettfo deleted the xrecord-no-flag branch May 26, 2016 20:10
@brettfo
Copy link
Member Author

brettfo commented May 26, 2016

One more note: I've recently made the change for this library to target .NETStandard1.2 so if you need the old portable-style project you can do the following locally:

git checkout 1c1d20ec73a69febb2ce5b453c096af9921bb127
git cherry-pick b630ab3596203c84cb77904bf717a9cbb1bdde77

The first commit (checkout) is where I merged the autocad-compat branch into master and the second commit is the commit from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant