Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bemessungsgrundlage for ges_krankenv Selbstständige #405

Conversation

JHermann99
Copy link
Contributor

@JHermann99 JHermann99 commented Jul 5, 2022

What problem do you want to solve?

Closes #404
Closes #174

Todo

  • Introduce Mindesteinkommen
    • calculate Mindesteinkommen
  • check upper limit of the Bemessungsgrundlage

@JHermann99
Copy link
Contributor Author

Closes #404

@JHermann99 JHermann99 self-assigned this Jul 5, 2022
@JHermann99
Copy link
Contributor Author

I just noticed, that the issue of mindesteinkommen has already been raised in #174 and a corresponding Zulip discussion, but does not seem to have been fixed. Additionally, the upper limit of 0.75*Bezugsgröße was also questioned. I also found no reference to this. Therefore I propose to implement the normal Beitragsbemessungsgrenze as described here.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@5c2da84). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9ca1725 differs from pull request most recent head 7b4cf16. Consider uploading reports for the commit 7b4cf16 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage        ?   92.50%           
=======================================
  Files           ?       76           
  Lines           ?     3720           
  Branches        ?        0           
=======================================
  Hits            ?     3441           
  Misses          ?      279           
  Partials        ?        0           
Impacted Files Coverage Δ
...sim/social_insurance_contributions/ges_krankenv.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristianZimpelmann ChristianZimpelmann requested review from mjbloemer and removed request for mjbloemer October 17, 2022 08:15
@ChristianZimpelmann ChristianZimpelmann marked this pull request as ready for review October 19, 2022 08:31
@hmgaudecker
Copy link
Collaborator

@JHermann99, apologies this has laid dormant for so long. We will take a look soon!

Could you just merge main into your branch? I made a bunch of changes to CI and docs recently, since you made the PR from your Github account I cannot do it myself... Else just try to transfer the branch to this repo, you do have write access now.

Please make sure to run pre-commit install before committing!

@JHermann99
Copy link
Contributor Author

Hi @hmgaudecker, unfortunately I was unable to automatically merge main into my branch and will not have the time to deal with this until next year. I have added you as a collaborator to my repo if you would like to get this done now. Otherwise I will do it early January. I am unsure how to move my branch to this repo, so if you have a good tutorial please let me know!

@hmgaudecker
Copy link
Collaborator

Cool, did this now since I had been working on that stuff the last couple of days, so many memories were still fresh.

Unfortunately, main changed quite heavily when it comes to the tests, unrelated to the stuff I had done. I left your version of sozialv_beitr.csv in the main directory so you can quickly compare whatever changes are necessary to src/_gettsim_tests/test_data/sozialv_beitr.csv (that is the same version as in main currently).

Next year is fine, of course !

@hmgaudecker
Copy link
Collaborator

Hi @JHermann99, do you have an idea when you might have a chance to take a look again? Happy to take over, too, if you will not be able to find the time (ideally after a short introduction into the test data).

Copy link
Collaborator

@hmgaudecker hmgaudecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@hmgaudecker hmgaudecker merged commit 00c5bde into iza-institute-of-labor-economics:main Mar 22, 2023
0 of 3 checks passed
@hmgaudecker hmgaudecker deleted the ges_krankenv_selbst_mindesteinkommen branch March 22, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants