Add option to disable auto reload on update #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request, @nisargjhaveri 🙇 ⭐️ I just tried testing this out, but it seems like it breaks something. With the "Auto reload on update" config option set to true, I tried updating the PDF (replacing it with a PDF with the same name), but the PDF didn't auto-reload in this package (which is unexpected, because the config option is set to true). If I do the same on master, the PDF reloads correctly. Happy to review this again if you'd like to take a look and fix that problem. |
nisargjhaveri
force-pushed
the
issue_161
branch
from
e83a435
to
2e4f400
Compare
|
Changed to Check now? |
Yep, looks good now 👍 Thanks again for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related, #161