Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Uncaught TypeError: serviceCallEvent.data.indexOf is not a function" #19

Closed
bradvogel opened this issue Jun 23, 2015 · 1 comment
Closed

"Uncaught TypeError: serviceCallEvent.data.indexOf is not a function" #19

bradvogel opened this issue Jun 23, 2015 · 1 comment

Comments

@bradvogel
Copy link
Contributor

I'm using your library inside a window that is getting external postmessages. Those messages are in an object format, so 'indexOf' isn't defined. Can you add protection to make sure serviceCallEvent.data is a string before calling indexOf?
@izuzak
Copy link
Owner

izuzak commented Jun 24, 2015

@bradvogel Sure, sounds like a good idea. Happy to review and merge a PR if you'd like to work on that?

bradvogel added a commit to bradvogel/pmrpc that referenced this issue Jun 24, 2015
@bradvogel
Ignore object payloads.
0514a77 
Fixes izuzak#19
@bradvogel bradvogel mentioned this issue Jun 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@izuzak @bradvogel