Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test case with real content (bjori site updated) #257

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

Simounet
Copy link
Contributor

I updated the test case but I was wondering why you were fetching real site instead of using existing fixture?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.495% when pulling 1433dd7 on Simounet:fix/bjori-site-updated into e115409 on j0k3r:master.

@j0k3r
Copy link
Owner

j0k3r commented Apr 14, 2021

Thanks for fixing it.
I fetch a real site because I want to test a real scenario instead of mocking stuff.
And sometimes site are updated and test fail.

@j0k3r j0k3r merged commit bf02bc5 into j0k3r:master Apr 14, 2021
@Simounet Simounet deleted the fix/bjori-site-updated branch April 14, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants