Ensure empty value from site_config are kept
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, when user wants to replace a string with nothing, `replace_string:` will be used and shouldn't be skipped. Also, adding more tests regarding previous PR.
jtojnar
reviewed
Jan 7, 2022
| ], | ||
| ], | ||
| ]); | ||
| $res = $graby->fetchContent('http://motherjones.com/politics/2012/02/mac-mcclelland-free-online-shipping-warehouses-labor'); |
There was a problem hiding this comment.
I wonder if we could store the response for mocking purposes in case the site ever gets down.
There was a problem hiding this comment.
I started that for few cases but it's really boring to perform 😫
https://github.com/j0k3r/graby/tree/master/tests/fixtures/content
There was a problem hiding this comment.
I guess I could try making an automatic rule for https://github.com/rectorphp/rector.
There was a problem hiding this comment.
You mean a rule that run the test suite and save content fetched in file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when user wants to replace a string with nothing,
replace_string:will be used and shouldn't be skipped.Also, adding more tests regarding previous PR.