Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fingerprints #338

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

HolgerAusB
Copy link
Contributor

  • new fingerprint for ippen.media based newspapers (German), the old one is not longer valid
  • new fingerprint for medium.com based websites, transformed from @fivefilters FulltextRSS config

@fivefilters
Copy link

There's also this for Substack that we use, if you'd like to add it, @HolgerAusB:

'<link rel="stylesheet" type="text/css" href="https://substackcdn.com/' -> fingerprint.substack.com

@j0k3r
Copy link
Owner

j0k3r commented Aug 24, 2023

Good job and thanks for your first PR @HolgerAusB!
I squashed your commits and fixed tests

@j0k3r j0k3r merged commit 52779cc into j0k3r:master Aug 24, 2023
9 checks passed
@HolgerAusB
Copy link
Contributor Author

OK @j0k3r, I don't understand, for what ContentExtractorTest.php is. No need to explain, I am not a real coder!

But you use here a wider range of the fingerprint and I just want be sure that this will not cause problems. You wrote:
... {"de.ippen-digital.story.onlineId":91197383} ...
but that number should be different for each article, I think.

And there is not test entry for the other two services I added: fingerprint.medium.com and fingerprint.substack.com

@HolgerAusB HolgerAusB deleted the additional-fingerprints branch August 24, 2023 13:04
@j0k3r
Copy link
Owner

j0k3r commented Aug 24, 2023

The test doesn't care about the id because the fingerprint doesn't check it.
So it's ok.
Yeah, no big deal if there is no test for other fingerpring :)

@HolgerAusB
Copy link
Contributor Author

@j0k3r, any ETA about when this is might going to be released and pushed to wallabag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants