Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mediapipe to 0.10.13 #40

Merged
merged 1 commit into from
May 10, 2024

Conversation

Malcolmnixon
Copy link
Contributor

@Malcolmnixon Malcolmnixon commented May 9, 2024

This PR updates mediapipe to 0.10.13 and uses mediapipe_setup.diff to apply the following additional patches:

  • Flatbuffers upgrade to 24.3.7
  • Remove preprocessor directives in function-like macros

@j20001970
Copy link
Owner

Do you plan to change mediapipe submodule to the fork? I'm not clear that why keep the PR as draft for now, and replace the submodule to a fork after the patch is upstreamed?

Personally if there are bugs that block the development, I would suggest putting the patch into mediapipe_setup.diff if the fix is not too big.

@Malcolmnixon
Copy link
Contributor Author

Having it point to my fork is just for testing - for supply-chain-security reasons it's better to keep the submodule linked to the authoritative source.

I like the suggestion of using mediapipe_setup.diff which would allow us to target the official 0.10.13 tag-commit and maintain the mandatory patches separately. Hopefully when 0.10.14 gets release we can retire those patches.

I'll try switching to that approach.

@Malcolmnixon Malcolmnixon changed the title Update mediapipe to 0.10.13+ Update mediapipe to 0.10.13 May 9, 2024
@Malcolmnixon Malcolmnixon marked this pull request as ready for review May 10, 2024 00:41
@j20001970 j20001970 merged commit 3dff4fd into j20001970:master May 10, 2024
5 checks passed
@j20001970
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants