Moved makeConfigObject up to FieldConverter interface #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. I get it and agree. Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeConfigObjectis what fillsdataTypeConfigObjinFieldType. Looking at the use ofgetDataTypeConfigObj()in ORMLite's default data persisters, it is exclusively used withinFieldConvertermethods. Therefore, I believe it is more appropriate for the config object to be a part of theFieldConverter.In practice this makes an important fix. Now the result of
getFieldConverter()is used to create the config object. A real world scenario where this was critical is in Oracle.BooleanCharTypecontains amakeConfigObjectbut it would never be called in this scenario without the change in this pull request.