Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Querystring support (WIP) #18

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Querystring support (WIP) #18

wants to merge 3 commits into from

Conversation

j4mie
Copy link
Owner

@j4mie j4mie commented Feb 8, 2020

Fixes #13

Having done a bit of work on this, I'm not totally sure this is a good idea.

  1. Where should the querystring values be available? Just in templates? Or should the JSON handler have access to them too?
  2. If the JSON handle should have access, how will that work? Currently the SQL is just bound with the params from the URL - will the URL and query params need to be namespaced or should they just be smashed into the same dict? Which should take precedence in that case?
  3. At the moment, the query is a dict where the values are lists, because ?foo=bar&foo=another is valid. Do I need to implement some sort of MultiValueDict to make this nicer?

This all seems like it might be a bit overcomplicated.. 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Querystring support
1 participant