Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point2PointJoint.getImpulseClamp() returns the damping value instead #918

Closed
stephengold opened this issue Sep 28, 2018 · 3 comments
Closed

Point2PointJoint.getImpulseClamp() returns the damping value instead #918

stephengold opened this issue Sep 28, 2018 · 3 comments
Assignees
@stephengold
Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect". Physics Issues with all kinds of Physics and their Bindings
Milestone
v3.2.2

Comments

@stephengold
Copy link
Member

Another probable copy-and-paste error:

    JNIEXPORT jfloat JNICALL
    Java_com_jme3_bullet_joints_Point2PointJoint_getImpulseClamp(
        JNIEnv * env,
        jobject object,
        jlong jointId) {

...

        return joint->m_setting.m_damping;
@stephengold stephengold self-assigned this Sep 28, 2018
@stephengold
Copy link
Member Author

Also, Point2PointJoint.getTau() has the exact same issue. Might as well fix both methods at once.

stephengold added a commit that referenced this issue Sep 30, 2018
@stephengold
tests and fixes for issues #918 and #919
8f26a3c
@stephengold stephengold added the bug Something that is supposed to work, but doesn't. More severe than a "defect". label Sep 30, 2018
@stephengold
Copy link
Member Author

Fixed in the master branch.

joliver82 pushed a commit to joliver82/jmonkeyengine that referenced this issue Nov 14, 2018
@stephengold @joliver82
tests and fixes for issues jMonkeyEngine#918 and jMonkeyEngine#919
bfe290a
@stephengold stephengold added this to the v3.2.2 milestone Dec 16, 2018
@pspeed42
Copy link
Contributor

pspeed42 commented Dec 20, 2018 •
edited
Loading

Ok for 3.2.2... but only because the machinations necessary for some app to rely on this incorrect values seems to overwhelm even my imagination.

stephengold added a commit that referenced this issue Dec 22, 2018
@stephengold
tests and fixes for issues #918 and #919
f71aad1
@stephengold stephengold added the Physics Issues with all kinds of Physics and their Bindings label Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephengold stephengold

Labels
bug Something that is supposed to work, but doesn't. More severe than a "defect". Physics Issues with all kinds of Physics and their Bindings
Projects
None yet
Milestone
v3.2.2
Development

No branches or pull requests
2 participants
@stephengold @pspeed42