Adding support for Specular-AA

[JohnLKkk]

see:http://www.jp.square-enix.com/tech/library/pdf/ImprovedGeometricSpecularAA(slides).pdf
https://docs.unity3d.com/Packages/com.unity.render-pipelines.high-definition@15.0/manual/Geometric-Specular-Anti-Aliasing.html
https://hub.jmonkeyengine.org/t/geometric-specular-anti-aliasing/47246/2
Usage: Simply set Material.setBoolean("SpecularAA", true);

[codex128]

Just some unused variables/functions that should be trimmed out if possible.

[codex128]

Ok, that looks good! 👍

[riccardobl]

Should we set this on by default? Are there any disadvantages in doing so? It doesn't seem computationally intensive

[JohnLKkk]

Should we set this on by default? Are there any disadvantages in doing so? It doesn't seem computationally intensive

Personally, I'm inclined to set its default value to True, however, others may not want anti-aliasing to be on by default (for some reason it seems most people use the low quality graphics mode in JME), so I'm not sure if the default here should be changed to True...

[JohnLKkk]

I forgot one thing, I will expose the two parameters Screen Space Variance and Threshold to material parameters tomorrow as well. For descriptions of them, refer to:
https://docs.unity3d.com/Packages/com.unity.render-pipelines.high-definition@15.0/manual/Geometric-Specular-Anti-Aliasing.html

[riccardobl]

I think we should make an exception in this case, since it won't impact performances too much and it is most likely a wanted feature, i doubt anyone likes aliasing in the reflections, but let's wait for a counterargument .

[zzuegg]

I would say make it default

[oxplay2]

agree, i think it should be default with just option to disable. (like its option now)

Tho i belive it might be nice to add later to PBRTerrain too? (it do not need to be this pr ofc)

[JohnLKkk]

agree, i think it should be default with just option to disable. (like its option now)

Tho i belive it might be nice to add later to PBRTerrain too? (it do not need to be this pr ofc)

Specular-AA has been added to PBRTerrain.

I think we should make an exception in this case, since it won't impact performances too much and it is most likely a wanted feature, i doubt anyone likes aliasing in the reflections, but let's wait for a counterargument .

I would say make it default

True has been set as the default value, and two material parameters (Screen Space Variance and Threshold) have been added.

[riccardobl]

Thank you! If there are no further objections, I will merge it within 24 hours.