Texture.load() doesn't trigger mipmap generation

[oxplay2]

initially: Simsilica/JmeConvert#4

I still might be wrong, but it seems like an issue.

Texture.java

    public void setMinFilter(MinFilter minificationFilter) {
        if (minificationFilter == null) {
            throw new IllegalArgumentException(
                    "minificationFilter can not be null.");
        }
        this.minificationFilter = minificationFilter;
        if (minificationFilter.usesMipMapLevels() && image != null && !image.isGeneratedMipmapsRequired() && !image.hasMipmaps()) {
            image.setNeedGeneratedMipmaps();
        }
    }

That is executed always first time by:

    public void setImage(Image image) {
        this.image = image;

        // Test if mipmap generation required.
        setMinFilter(getMinFilter());
    }

GLTFLoader execute it second time for setting proper filtering by:

        if (minFilter != null) {
            texture.setMinFilter(minFilter);
        }

BUT J3O importer when using texture.read capsule do not execute it second time, causing not setting proper bollean for generateMipMaps.

Here is texture.read:

    public void read(JmeImporter importer) throws IOException {
        InputCapsule capsule = importer.getCapsule(this);
        name = capsule.readString("name", null);
        key = (TextureKey) capsule.readSavable("key", null);

        // load texture from key, if available
        if (key != null) {
            // key is available, so try the texture from there.
            try {
                Texture loadedTex = importer.getAssetManager().loadTexture(key);
                image = loadedTex.getImage();
            } catch (AssetNotFoundException ex){
                Logger.getLogger(Texture.class.getName()).log(Level.SEVERE, "Cannot locate texture {0}", key);
                image = PlaceholderAssets.getPlaceholderImage(importer.getAssetManager());
            }
        }else{
            // no key is set on the texture. Attempt to load an embedded image
            image = (Image) capsule.readSavable("image", null);
            if (image == null){
                // TODO: what to print out here? the texture has no key or data, there's no useful information ..
                // assume texture.name is set even though the key is null
                Logger.getLogger(Texture.class.getName())
                        .log(Level.SEVERE, "Cannot load embedded image {0}", toString());
            }
        }

        anisotropicFilter = capsule.readInt("anisotropicFilter", 1);
        minificationFilter = capsule.readEnum("minificationFilter",
                MinFilter.class,
                MinFilter.BilinearNoMipMaps);
        magnificationFilter = capsule.readEnum("magnificationFilter",
                MagFilter.class, MagFilter.Bilinear);
    }

and after setting minificationFilter this do not execute same glued code as setMinFilter() do.

[JohnLKkk]

You are right, this is what caused incorrect texture filtering + mipmapping results when rendering j3o. I tested it locally.

see：https://hub.jmonkeyengine.org/t/gltf-to-j3o-texture-filtering-issue/47197/73

[JohnLKkk]

I have fixed it here：#2134