[#3748] Add public Routine T getValue(Parameter<T>) and setValue(Para…

…meter<T>, T) methods
jOOQ · Mar 2, 2015 · ab8b6a1 · ab8b6a1
1 parent cd58f98
commit ab8b6a1
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 12 deletions.
diff --git a/jOOQ/src/main/java/org/jooq/Routine.java b/jOOQ/src/main/java/org/jooq/Routine.java
@@ -89,6 +89,10 @@
  */
 public interface Routine<T> extends QueryPart {
 
+    // -------------------------------------------------------------------------
+    // XXX: Meta information
+    // -------------------------------------------------------------------------
+
     /**
      * Get the routine schema
      */
@@ -143,15 +147,9 @@ public interface Routine<T> extends QueryPart {
      */
     List<Parameter<?>> getParameters();
 
-    /**
-     * @return The routine's return value (if it is a function)
-     */
-    T getReturnValue();
-
-    /**
-     * @return The routine's results (if available)
-     */
-    List<Result<Record>> getResults();
+    // -------------------------------------------------------------------------
+    // XXX: Call API
+    // -------------------------------------------------------------------------
 
     /**
      * Execute the stored object using a {@link Configuration} object
@@ -166,4 +164,28 @@ public interface Routine<T> extends QueryPart {
      * @throws DataAccessException if something went wrong executing the query
      */
     int execute() throws DataAccessException;
+
+    // -------------------------------------------------------------------------
+    // XXX: Call data
+    // -------------------------------------------------------------------------
+
+    /**
+     * Set the routine's IN value for an IN parameter.
+     */
+    <Z> void setValue(Parameter<Z> parameter, Z value);
+
+    /**
+     * @return The routine's OUT value for an OUT parameter.
+     */
+    <Z> Z getValue(Parameter<Z> parameter);
+
+    /**
+     * @return The routine's return value (if it is a function)
+     */
+    T getReturnValue();
+
+    /**
+     * @return The routine's results (if available)
+     */
+    List<Result<Record>> getResults();
 }
diff --git a/jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java b/jOOQ/src/main/java/org/jooq/impl/AbstractRoutine.java
@@ -198,15 +198,16 @@ protected <X, Y> AbstractRoutine(String name, Schema schema, Package pkg, DataTy
     // Initialise a routine call
     // ------------------------------------------------------------------------
 
-    protected final void setNumber(Parameter<? extends Number> parameter, Number value) {
+    protected final <N extends Number> void setNumber(Parameter<N> parameter, Number value) {
         setValue(parameter, Convert.convert(value, parameter.getType()));
     }
 
     protected final void setNumber(Parameter<? extends Number> parameter, Field<? extends Number> value) {
         setField(parameter, value);
     }
 
-    protected final void setValue(Parameter<?> parameter, Object value) {
+    @Override
+    public final <Z> void setValue(Parameter<Z> parameter, Z value) {
         setField(parameter, val(value, parameter.getDataType()));
     }
 
@@ -645,8 +646,9 @@ public final List<Result<Record>> getResults() {
         return results;
     }
 
+    @Override
     @SuppressWarnings("unchecked")
-    protected final <Z> Z getValue(Parameter<Z> parameter) {
+    public final <Z> Z getValue(Parameter<Z> parameter) {
         return (Z) outValues.get(parameter);
     }