[#8547] Fix SQLITE comparisons against dialect

SQLITE should normally be compared against the dialect family. Also replace some occurrences of `context.configuration().dialect()` with `context.dialect()`.
jOOQ · May 28, 2019 · d751d6e · d751d6e
1 parent 2b26053
commit d751d6e
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/jOOQ-meta/src/main/java/org/jooq/meta/Databases.java b/jOOQ-meta/src/main/java/org/jooq/meta/Databases.java
@@ -133,6 +133,10 @@ public static final Class<? extends Database> databaseClass(SQLDialect dialect)
 
 
             case POSTGRES:         result = PostgresDatabase.class;         break;
+
+
+
+
             case SQLITE:           result = SQLiteDatabase.class;           break;
 
             case DEFAULT:

diff --git a/jOOQ/src/main/java/org/jooq/impl/CaseWhenStepImpl.java b/jOOQ/src/main/java/org/jooq/impl/CaseWhenStepImpl.java
@@ -226,7 +226,7 @@ public final void accept(Context<?> ctx) {
                .visit(K_CASE);
 
             int size = compareValues.size();
-            switch (ctx.configuration().dialect()) {
+            switch (ctx.dialect()) {
 
                 // The DERBY dialect doesn't support the simple CASE clause
                 case DERBY: {

diff --git a/jOOQ/src/main/java/org/jooq/impl/DefaultBinding.java b/jOOQ/src/main/java/org/jooq/impl/DefaultBinding.java
@@ -1444,7 +1444,7 @@ final void set0(BindingSetSQLOutputContext<U> ctx, BigInteger value) throws SQLE
         final BigInteger get0(BindingGetResultSetContext<U> ctx) throws SQLException {
 
             // The SQLite JDBC driver doesn't support BigDecimals
-            if (ctx.configuration().dialect() == SQLDialect.SQLITE)
+            if (ctx.family() == SQLDialect.SQLITE)
                 return Convert.convert(ctx.resultSet().getString(ctx.index()), BigInteger.class);
 
             BigDecimal b = ctx.resultSet().getBigDecimal(ctx.index());

diff --git a/jOOQ/src/main/java/org/jooq/impl/Function.java b/jOOQ/src/main/java/org/jooq/impl/Function.java
@@ -642,7 +642,7 @@ final void toSQLFunctionName(Context<?> ctx) {
         if (name != null)
             ctx.visit(name);
         else if (term != null)
-            ctx.sql(term.translate(ctx.configuration().dialect()));
+            ctx.sql(term.translate(ctx.dialect()));
         else
             ctx.sql(getName());
     }

diff --git a/jOOQ/src/main/java/org/jooq/impl/FunctionTable.java b/jOOQ/src/main/java/org/jooq/impl/FunctionTable.java
@@ -82,7 +82,7 @@ public final Table<R> as(Name as, Name... fieldAliases) {
 
     @Override
     public final void accept(Context<?> ctx) {
-        switch (ctx.configuration().dialect()) {
+        switch (ctx.dialect()) {
             case HSQLDB: {
                 ctx.visit(K_TABLE).sql('(').visit(function).sql(')');
                 break;
@@ -99,7 +99,7 @@ public final void accept(Context<?> ctx) {
             }
 
             default:
-                throw new SQLDialectNotSupportedException("FUNCTION TABLE is not supported for " + ctx.configuration().dialect());
+                throw new SQLDialectNotSupportedException("FUNCTION TABLE is not supported for " + ctx.dialect());
         }
     }
 

diff --git a/jOOQ/src/main/java/org/jooq/impl/MetaImpl.java b/jOOQ/src/main/java/org/jooq/impl/MetaImpl.java
@@ -429,7 +429,7 @@ private final Result<Record> getColumns(String schema, String table) {
 
             // SQLite JDBC's DatabaseMetaData.getColumns() can only return a single
             // table's columns
-            if (columnCache == null && configuration.dialect() != SQLITE) {
+            if (columnCache == null && configuration.family() != SQLITE) {
                 Result<Record> columns = getColumns0(schema, "%");
 
                 Field<String> tableCat   = (Field<String>) columns.field(0); // TABLE_CAT