Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SQLDialect.SQLITE_3_28 and SQLDialect.SQLITE_3_25 #8547

Closed
lukaseder opened this issue Apr 18, 2019 · 0 comments
Closed

Add SQLDialect.SQLITE_3_28 and SQLDialect.SQLITE_3_25 #8547

lukaseder opened this issue Apr 18, 2019 · 0 comments
Labels
C: Functionality E: Enterprise Edition E: Professional Edition P: Medium R: Fixed T: Enhancement
Milestone
Version 3.12.0

Comments

@lukaseder
Copy link
Member

SQLite has introduced a few new features recently, including better window function support, see:
https://www.sqlite.org/changes.html#version_3_28_0

It makes sense to start distinguishing between SQLite version numbers as well, specifically because we can now use native WINDOW clause support starting with SQLite 3.28, which has currently been emulated:

Standard and PostgreSQL, others

SELECT count(*) OVER win
FROM t1
WINDOW win AS (PARTITION BY a ORDER BY c)

SQLite 3.25

select count(*) over (partition by a order by c)
from t1
@lukaseder lukaseder added this to the Version 3.12.0 milestone Apr 18, 2019
@lukaseder lukaseder changed the title Add SQLDialect.SQLITE_3_28 amd SQLDialect.SQLITE_3_25 Add SQLDialect.SQLITE_3_28 and SQLDialect.SQLITE_3_25 Apr 18, 2019
lukaseder added a commit that referenced this issue Apr 18, 2019
@lukaseder
[#8547] Add SQLDialect.SQLITE_3_28 and SQLDialect.SQLITE_3_25
c7beac5
knutwannheden added a commit that referenced this issue May 28, 2019
@knutwannheden
[#8547] Add missing SQLITE_3_x cases to switches
de263dc 
Add missing cases for SQLITE_3_25 and SQLITE_3_28 in dialect switches.
knutwannheden added a commit that referenced this issue May 28, 2019
@knutwannheden
[#8547] Fix SQLITE comparisons against dialect
d751d6e 
SQLITE should normally be compared against the dialect family.

Also replace some occurrences of `context.configuration().dialect()`
with `context.dialect()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality E: Enterprise Edition E: Professional Edition P: Medium R: Fixed T: Enhancement
Projects
None yet
Milestone
Version 3.12.0
Development

No branches or pull requests
1 participant
@lukaseder