Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullPointerException when Database.setOnError(null) is called #10335

Closed
lukaseder opened this issue Jul 1, 2020 · 1 comment
Closed

NullPointerException when Database.setOnError(null) is called #10335

lukaseder opened this issue Jul 1, 2020 · 1 comment
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Defect
Projects
3.14 Other improvements
Milestone
Version 3.14.0

Comments

@lukaseder
Copy link
Member

When Configuration.onError is null, then an unrelated NullPointerException is thrown:

12:32:36,184 [ERROR] Error while generating table X
java.lang.NullPointerException
    at org.jooq.meta.AbstractDatabase.onError (AbstractDatabase.java:2552)
    at org.jooq.meta.AbstractDatabase.getRelations (AbstractDatabase.java:2020)
    at org.jooq.meta.DefaultColumnDefinition.getPrimaryKey (DefaultColumnDefinition.java:91)
    at org.jooq.meta.AbstractTableDefinition.getPrimaryKey (AbstractTableDefinition.java:86)
    at org.jooq.codegen.JavaGenerator.generateTable (JavaGenerator.java:4297)
    at org.jooq.codegen.JavaGenerator.generateTable (JavaGenerator.java:4291)
    at org.jooq.codegen.JavaGenerator.generateTables (JavaGenerator.java:4278)
    at org.jooq.codegen.JavaGenerator.generate (JavaGenerator.java:548)
    at org.jooq.codegen.JavaGenerator.generate (JavaGenerator.java:503)
    at org.jooq.codegen.JavaGenerator.generate (JavaGenerator.java:424)
    at org.jooq.codegen.GenerationTool.run0 (GenerationTool.java:866)
    at org.jooq.codegen.GenerationTool.run (GenerationTool.java:227)
    at org.jooq.codegen.GenerationTool.generate (GenerationTool.java:222)
    at org.jooq.codegen.maven.Plugin.execute (Plugin.java:207)

We should just implement the default behaviour of OnError.FAIL
@lukaseder lukaseder added this to the Version 3.14.0 milestone Jul 1, 2020
@lukaseder lukaseder added this to To do in 3.14 Other improvements via automation Jul 1, 2020
lukaseder added a commit that referenced this issue Jul 1, 2020
@lukaseder
[#10335] NullPointerException when Database.setOnError(null) is called
16e6075
3.14 Other improvements automation moved this from To do to Done Jul 1, 2020
@lukaseder
Copy link
Member Author

This is unlikely to happen in client code, which doesn't call these methods explicitly, programmatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Defect
Projects
No open projects
3.14 Other improvements
  
Done
Milestone
Version 3.14.0
Development

No branches or pull requests
1 participant
@lukaseder