Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when parsing Oracle (+) operator with ParseUnknownFunctions.IGNORE #10670

Closed
lukaseder opened this issue Sep 23, 2020 · 2 comments
Closed

Error when parsing Oracle (+) operator with ParseUnknownFunctions.IGNORE #10670

lukaseder opened this issue Sep 23, 2020 · 2 comments
Labels
C: Parser E: Enterprise Edition E: Professional Edition P: Medium R: Fixed T: Defect
Projects
3.14 Other improvements
Milestone
Version 3.14.0

Comments

@lukaseder
Copy link
Member

Parsing this fails, when ParseUnknownFunctions.IGNORE is active:

select 1 from a, b where a.x(+) = b.y

The error is:

org.jooq.impl.ParserException: Identifier expected: [1:31] select 1 from a, b where a.x(+[*]) = b.y
	at org.jooq.impl.ParserContext.expected(ParserImpl.java:12109)
	at org.jooq.impl.ParserImpl.parseName(ParserImpl.java:10150)
	at org.jooq.impl.ParserImpl.parseFieldNameOrSequenceExpression(ParserImpl.java:10064)
	at org.jooq.impl.ParserImpl.parseTerm(ParserImpl.java:7224)
	at org.jooq.impl.ParserImpl.parseUnaryOps(ParserImpl.java:6485)
	at org.jooq.impl.ParserImpl.parseExp(ParserImpl.java:6460)
	at org.jooq.impl.ParserImpl.parseFactor(ParserImpl.java:6437)
	at org.jooq.impl.ParserImpl.parseSum(ParserImpl.java:6389)
	at org.jooq.impl.ParserImpl.parseNumericOp(ParserImpl.java:6374)
	at org.jooq.impl.ParserImpl.parseCollated(ParserImpl.java:6348)
	at org.jooq.impl.ParserImpl.parseConcat(ParserImpl.java:6338)
	at org.jooq.impl.ParserImpl.parsePredicate(ParserImpl.java:5267)
	at org.jooq.impl.ParserImpl.parseNot(ParserImpl.java:5197)
	at org.jooq.impl.ParserImpl.parseAnd(ParserImpl.java:5187)
	at org.jooq.impl.ParserImpl.parseOr(ParserImpl.java:5178)
	at org.jooq.impl.ParserImpl.parseField(ParserImpl.java:6255)
	at org.jooq.impl.ParserImpl.parseField(ParserImpl.java:6180)
	at org.jooq.impl.ParserImpl.parseFieldNameOrSequenceExpression(ParserImpl.java:10080)
	at org.jooq.impl.ParserImpl.parseTerm(ParserImpl.java:7224)
	at org.jooq.impl.ParserImpl.parseUnaryOps(ParserImpl.java:6483)
	at org.jooq.impl.ParserImpl.parseExp(ParserImpl.java:6460)
	at org.jooq.impl.ParserImpl.parseFactor(ParserImpl.java:6437)
	at org.jooq.impl.ParserImpl.parseSum(ParserImpl.java:6389)
	at org.jooq.impl.ParserImpl.parseNumericOp(ParserImpl.java:6374)
	at org.jooq.impl.ParserImpl.parseCollated(ParserImpl.java:6348)
	at org.jooq.impl.ParserImpl.parseConcat(ParserImpl.java:6338)
	at org.jooq.impl.ParserImpl.parsePredicate(ParserImpl.java:5267)
	at org.jooq.impl.ParserImpl.parseNot(ParserImpl.java:5197)
	at org.jooq.impl.ParserImpl.parseAnd(ParserImpl.java:5187)
	at org.jooq.impl.ParserImpl.parseOr(ParserImpl.java:5178)
	at org.jooq.impl.ParserImpl.parseCondition(ParserImpl.java:5174)
	at org.jooq.impl.ParserImpl.parseQueryPrimary(ParserImpl.java:1506)
	at org.jooq.impl.ParserImpl.parseQueryTerm(ParserImpl.java:1378)
	at org.jooq.impl.ParserImpl.parseQueryExpressionBody(ParserImpl.java:1349)
	at org.jooq.impl.ParserImpl.parseSelect(ParserImpl.java:1132)
	at org.jooq.impl.ParserImpl.parseSelect(ParserImpl.java:1127)
	at org.jooq.impl.ParserImpl.parseQuery(ParserImpl.java:984)
	at org.jooq.impl.ParserImpl.parseQuery(ParserImpl.java:668)
	at org.jooq.impl.ParserImpl.parseQuery(ParserImpl.java:662)
	at org.jooq.impl.AbstractParserTest.assertQueryEquals(AbstractParserTest.java:251)
	at org.jooq.impl.ParserImplTest.testSelectOracleOuterJoinWithParseUnknownFunctions(ParserImplTest.java:442)
@lukaseder lukaseder added this to the Version 3.14.0 milestone Sep 23, 2020
@lukaseder lukaseder added this to To do in 3.14 Other improvements via automation Sep 23, 2020
lukaseder added a commit that referenced this issue Sep 23, 2020
@lukaseder
[#10670] Error when parsing Oracle (+) operator with ParseUnknownFunc…
f5fb7b3 
…tions.IGNORE
@lukaseder
Copy link
Member Author

Fixed in jOOQ 3.14.0. Backport scheduled for 3.13.5 (#10673)

3.14 Other improvements automation moved this from To do to Done Sep 23, 2020
lukaseder added a commit that referenced this issue Sep 23, 2020
@lukaseder
[#10670] Error when parsing Oracle (+) operator with
91bd952 
ParseUnknownFunctions.IGNORE
@lukaseder lukaseder mentioned this issue Sep 23, 2020
Closed
@lukaseder
Copy link
Member Author

Related issue: #10675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Parser E: Enterprise Edition E: Professional Edition P: Medium R: Fixed T: Defect
Projects
No open projects
3.14 Other improvements
  
Done
Milestone
Version 3.14.0
Development

No branches or pull requests
1 participant
@lukaseder