Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a record constructor taking a generated POJO #11183

Closed
lukaseder opened this issue Jan 4, 2021 · 3 comments
Closed

Generate a record constructor taking a generated POJO #11183

lukaseder opened this issue Jan 4, 2021 · 3 comments
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Enhancement
Projects
3.14 Embeddable Types
Milestone
Version 3.15.0

Comments

@lukaseder
Copy link
Member

lukaseder commented Jan 4, 2021 •
edited

When POJOs are generated, it would make sense to generate a record constructor taking the POJO as an argument.

This is similar to the discussion here, but for constructors:

This would greatly simplify generated code in DAOs when implementing #11182, where new EmbeddableRecord(embeddablePojo) would be very useful.

The difficulty is with nested records/pojos. Seeing that this might produce unforeseen compilation errors, it needs to be guarded by a new flag.
@lukaseder lukaseder added this to the Version 3.15.0 milestone Jan 4, 2021
@lukaseder lukaseder added this to To do in 3.14 Embeddable Types via automation Jan 4, 2021
@lukaseder lukaseder mentioned this issue Jan 4, 2021
Closed
lukaseder added a commit that referenced this issue Jan 4, 2021
@lukaseder
[#11182] Generate DAO.fetchByXYZ() methods for embeddable types
0a8cc44 
This includes:

- [#11183] Generate record constructor taking a generated POJO
- [#11187] Add DAO.fetch(Field<Z>, Collection<? extends Z>)
3.14 Embeddable Types automation moved this from To do to Done Jan 4, 2021
@lukaseder lukaseder reopened this Jan 14, 2021
3.14 Embeddable Types automation moved this from Done to In progress Jan 14, 2021
@lukaseder
Copy link
Member Author

lukaseder commented Jan 14, 2021 •
edited

There are some compilation errors in our integration tests when using UDTs. Let's investigate

@lukaseder
Copy link
Member Author

There are also StackOverflowError at runtime, because our default ConverterProvider will now pick the wrong constructor in some mapping scenario and recurse infinitely, trying to look up the correct converter.

@lukaseder lukaseder mentioned this issue Apr 14, 2021
Open
lukaseder added a commit that referenced this issue Apr 14, 2021
@lukaseder
[#11183] Fix UDT code generation
04283e9
lukaseder added a commit that referenced this issue Apr 14, 2021
@lukaseder
[#11183] kotlin and scala fixes
c2f8428
3.14 Embeddable Types automation moved this from In progress to Done Apr 14, 2021
lukaseder added a commit that referenced this issue Apr 15, 2021
@lukaseder
[#11183] Handle POJO nullability in constructors
4746bc2
This was referenced Mar 8, 2022
Closed
Closed
@lukaseder lukaseder mentioned this issue Mar 21, 2022
Closed
@lukaseder
Copy link
Member Author

An edge case code generation compilation error: #13315

@lukaseder lukaseder mentioned this issue Jul 8, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Enhancement
Projects
3.14 Embeddable Types
  
Done
Milestone
Version 3.15.0
Development

No branches or pull requests
1 participant
@lukaseder