Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser parses PRIMARYKEY as PRIMARY KEY #11290

Closed
lukaseder opened this issue Jan 22, 2021 · 3 comments
Closed

Parser parses PRIMARYKEY as PRIMARY KEY #11290

lukaseder opened this issue Jan 22, 2021 · 3 comments
Labels
C: Parser E: All Editions P: High R: Fixed T: Defect
Projects
3.15 Other improvements
Milestone
Version 3.15.0

Comments

@lukaseder
Copy link
Member

lukaseder commented Jan 22, 2021 •
edited

Our parsing utilities seem to parse PRIMARYKEY and PRIMARY KEY as the same thing. This seems to apply to other compound keywords as well, e.g. GROUPBY is parsed as GROUP BY.

This is probably a recent regression from a refactoring. I don't think this was the case when the parser was first created.
@lukaseder lukaseder added this to the Version 3.15.0 milestone Jan 22, 2021
@lukaseder lukaseder added this to To do in 3.15 Other improvements via automation Jan 22, 2021
@lukaseder
Copy link
Member Author

lukaseder commented Jan 22, 2021 •
edited

robably introduced with #11093 in 3.15 only, not yet released in 3.14. Nope, can be reproduced in 3.14 as well!

@lukaseder
Copy link
Member Author

Maybe as old as #6485 (3.11)?

lukaseder added a commit that referenced this issue Jan 22, 2021
@lukaseder
[#11290] Parser parses PRIMARYKEY as PRIMARY KEY
0cca2dc
lukaseder added a commit that referenced this issue Jan 22, 2021
@lukaseder
[#11290] Parser parses PRIMARYKEY as PRIMARY KEY
968ff01
@lukaseder
Copy link
Member Author

Fixed in jOOQ 3.15.0 and 3.14.6 (#11291)

3.15 Other improvements automation moved this from To do to Done Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Parser E: All Editions P: High R: Fixed T: Defect
Projects
No open projects
3.15 Other improvements
  
Done
Milestone
Version 3.15.0
Development

No branches or pull requests
1 participant
@lukaseder