Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataType.array() as a DSL style shortcut for getArrayDataType() #13971

Closed
lukaseder opened this issue Sep 9, 2022 · 0 comments
Closed

Add DataType.array() as a DSL style shortcut for getArrayDataType() #13971

lukaseder opened this issue Sep 9, 2022 · 0 comments
Labels
C: Code Generation C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
3.18 Other improvements
Milestone
Version 3.18.0

Comments

@lukaseder
Copy link
Member

All the INTEGER.getArrayDataType().getArrayDataType() calls generated for multi dimensional arrays (#252) are a bit unwieldy. We have a couple of convenience methods on DataType that correspond more to SQL syntax, such as null_() and notNull(), which represent the historic versions like nullable(true). Would certainly make sense to introduce array() as well for this purpose, to get INTEGER.array().array()
@lukaseder lukaseder added this to the Version 3.18.0 milestone Sep 9, 2022
@lukaseder lukaseder added this to To do in 3.18 Other improvements via automation Sep 9, 2022
lukaseder added a commit that referenced this issue Sep 9, 2022
@lukaseder
[#13971] Add DataType.array() as a DSL style shortcut for
e25723a 
getArrayDataType()
3.18 Other improvements automation moved this from To do to Done Sep 12, 2022
lukaseder added a commit that referenced this issue Dec 15, 2022
@lukaseder
[#5799] Add support for the SQL Standard WITH ORDINALITY clause
ad66b4e 
This includes:
- [#14406] The AutoAlias feature isn't applied from within the JOIN tree, only from the TableList
- Update AutoAlias to allow for auto-aliasing other tables than this
- Add NoAutoAlias to prevent aliasing in derived column list emulations
- Removed TableWithOrdinalityStep again, all Table types are supported
- Implement emulations
- Added an AbstractAutoAliasTable base implementation for AliasTable
- [#14409] Refactor Values to implement AutoAlias
- [#13971] Use DataType::array internally
- [#14388] Fix data type of ArrayConcat expression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
No open projects
3.18 Other improvements
Done
Milestone
Version 3.18.0
Development

No branches or pull requests
1 participant
@lukaseder