New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Settings.batchSize also to other batch API #14840
Comments
Looking into this now. The implementation will specifically exclude the R2DBC implementation for now. |
There are 2 ways to implement this:
The first approach is easier to implement, but I think the second one is preferrable, especially in the |
The |
Hmm, regrettably, the |
I'll investigate this a bit more. Not too happy with how |
I'll investigate |
jOOQ 3.14 introduced the
Settings.batchSize
(#10693), to govern the size of a batch collected in aBatchedConnection
. It's not unlikely users would expect thisSettings
also to apply to any otherBatch
API usage, given the generic name of theSettings
. For example:https://stackoverflow.com/q/75820566/521799
Changing this can be done in 2 ways:
By adding another flag that allows for opting in or out of this additional behaviourInteger.MAX_VALUE
and set thebatchSize
only explicitly on aBatchedConnection
, when needed. This is the one.This also affects:
Loader
implementation, as it uses theBatch
API behind the scenes.BatchSingle
BatchMultiple
BatchCRUD
is usingBatchSingle
orBatchMultiple
behind the scenes, and as such, receives the same chunked behaviour.This does not affect
ExecuteListener
lifecycle (we're not reusing thePreparedStatement
, callingclearBatch()
)The text was updated successfully, but these errors were encountered: