We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We're currently recursing into Name and Comment parts from within SchemaImpl and CatalogImpl methods $replace() and $traverse():
Name
Comment
SchemaImpl
CatalogImpl
$replace()
$traverse()
@Override public final <R> R $traverse(Traverser<?, R> traverser) { return QOM.traverse(traverser, this, getQualifiedName()); } @Override public final QueryPart $replace(Replacer replacer) { return QOM.replace(this, getQualifiedName(), getCommentPart(), CatalogImpl::new, replacer); }
This isn't being done in any other Named type, including TableImpl, TableFieldImpl, and many many others:
Named
TableImpl
TableFieldImpl
Let's remove this recursion for these reasons:
The text was updated successfully, but these errors were encountered:
Since there might be a (very unlikely) behavioural regression in a customer implementation of a Replacer call, I won't backport this change.
Replacer
Sorry, something went wrong.
[#15022] SchemaImpl and CatalogImpl () and ()
ce7508e
methods shouldn't recurse into Name or Comment parts
No branches or pull requests
We're currently recursing into
Name
andComment
parts from withinSchemaImpl
andCatalogImpl
methods$replace()
and$traverse()
:This isn't being done in any other
Named
type, includingTableImpl
,TableFieldImpl
, and many many others:Let's remove this recursion for these reasons:
The text was updated successfully, but these errors were encountered: