AbstractDatabase::markUsed doesn't work in some edge cases

[lukaseder]

While testing #12985, I've discovered a glitch regarding forced types, which hasn't appeared yet with the Maven plugin, but does with the new gradle plugin.

Despite forced types being applied correctly, this is being logged:

Unused forced type       : <priority>0</priority><name>VARCHAR(10)</name><autoConverter>true</autoConverter><includeExpression>J</includeExpression><nullability>ALL</nullability><objectType>ALL</objectType>
Unused forced type       : <priority>0</priority><name>BIGINT</name><autoConverter>true</autoConverter><includeExpression>K</includeExpression><nullability>ALL</nullability><objectType>ALL</objectType>

The reason is because we add the forced types to the AbstractDatabase.unusedForcedTypes hash set, and then modify them on some occasions, e.g. to set autoConverter to true. Obviously, that's forbidden by the HashSet contract, because now, the hashCode (and equals behaviour) changes.

A workaround would be to set autoConverter = true, but similar things happen when using the deprecated expression value, for example, which is copied to includeExpression.

There are a few ways to fix this:

• Fix equals() and hashCode(), making them more intelligent (hard to check)
• Use an IdentityHashMap instead (possibly regressing in the future, when we create clones of ForcedType instances, which we currently don't do)
• Delay initialisation of the HashSet until all the ForcedType values have been patched (probably the best solution here)
• Remove and re-add any ForcedType that is modified (hard to remember)

[lukaseder]

Fixed in jOOQ versions:

• 3.19.0
• 3.18.8 (AbstractDatabase::markUsed doesn't work in some edge cases - Merge [#15918] #15919)
• 3.17.17 (AbstractDatabase::markUsed doesn't work in some edge cases - Merge [#15918] #15920)
• 3.16.23 (AbstractDatabase::markUsed doesn't work in some edge cases - Merge [#15918] #15921)