Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderTable.WHEN_MULTIPLE_TABLES doesn't work correctly in correlated subqueries #15996

Closed
lukaseder opened this issue Dec 27, 2023 · 1 comment
Closed

RenderTable.WHEN_MULTIPLE_TABLES doesn't work correctly in correlated subqueries #15996

lukaseder opened this issue Dec 27, 2023 · 1 comment
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Defect
Projects
3.20 Other improvements
Milestone
Version 3.20.0

Comments

@lukaseder
Copy link
Member

lukaseder commented Dec 27, 2023 •
edited
Loading

The RenderTable.WHEN_MULTIPLE_TABLE flag introduced with #8893 (probably) doesn't work correctly in correlated subqueries, where we must disambiguate between tables from the local scope and tables from the outer scope. This affects both:

  • Normal correlated subqueries
  • Implicit path correlations

A prudent approach would be to always qualify fields with their tables in all scalar subqueries. Derived tables aren't affected, except for lateral derived tables, which are also correlated.

This likely also affects WHEN_AMBIGUOUS_COLUMNS.

See also:
@lukaseder lukaseder added this to the Version 3.20.0 milestone Dec 27, 2023
This was referenced Dec 27, 2023
Closed
Closed
@lukaseder lukaseder added this to To do in 3.20 Other improvements via automation Dec 28, 2023
This was referenced Jan 22, 2024
Closed
Closed
@lukaseder
Copy link
Member Author

Fixed in versions:

jOOQ 3.17 didn't have #8893 yet, so this bugfix isn't needed in 3.17

3.20 Other improvements automation moved this from To do to Done Jan 22, 2024
lukaseder added a commit that referenced this issue Jan 22, 2024
@lukaseder
[#15998] [#15996] RenderTable fixes
1f07cdf 
This includes:

- [#16121] Add Context.scopeParts(Class<Q>): Iterable<Q> to
allow for iterating over the values that are currently in scope
- [#15998] RenderTable.WHEN_AMBIGUOUS_COLUMNS doesn't cover all
ambiguous column name cases
- [#15996] RenderTable.WHEN_MULTIPLE_TABLES doesn't work
correctly in correlated subqueries
lukaseder added a commit that referenced this issue Jan 22, 2024
@lukaseder
[#15998] [#15996] RenderTable fixes
5d725e2 
This includes:

- [#16121] Add Context.scopeParts(Class<Q>): Iterable<Q> to
allow for iterating over the values that are currently in scope
- [#15998] RenderTable.WHEN_AMBIGUOUS_COLUMNS doesn't cover all
ambiguous column name cases
- [#15996] RenderTable.WHEN_MULTIPLE_TABLES doesn't work
correctly in correlated subqueries
lukaseder added a commit that referenced this issue Jan 22, 2024
@lukaseder
[#15998] [#15996] RenderTable fixes
ed915ed 
This includes:

- [#16121] Add Context.scopeParts(Class<Q>): Iterable<Q> to
allow for iterating over the values that are currently in scope
- [#15998] RenderTable.WHEN_AMBIGUOUS_COLUMNS doesn't cover all
ambiguous column name cases
- [#15996] RenderTable.WHEN_MULTIPLE_TABLES doesn't work
correctly in correlated subqueries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Defect
Projects
3.20 Other improvements
Done
Milestone
Version 3.20.0
Development

No branches or pull requests
1 participant
@lukaseder