Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess generics from integration tests #3198

Closed
lukaseder opened this issue Apr 19, 2014 · 1 comment
Closed

Remove excess generics from integration tests #3198

lukaseder opened this issue Apr 19, 2014 · 1 comment

Comments

@lukaseder
Copy link
Member

Current integration tests abstract over generated classes from various SQL dialects through generics:

public abstract class jOOQAbstractTest<

        // T_AUTHOR table
        A extends UpdatableRecord<A> & Record6<Integer, String, String, ? extends java.util.Date, Integer, ?>,

        // T_AUTHOR pojo
        AP,

        // T_BOOK table
        B extends UpdatableRecord<B>,

        // T_BOOK_STORE table
        S extends UpdatableRecord<S> & Record1<String>,

        // T_BOOK_TO_BOOK_STORE table
        B2S extends TableRecord<B2S> & Record3<String, Integer, Integer>,

        // MULTI_SCHEMA.T_BOOK_SALE table
        BS extends UpdatableRecord<BS>,

        // V_LIBRARY view
        L extends TableRecord<L>/* & Record2<String, String>*/,

        // T_ARRAYS table
        X extends TableRecord<X>,

        // T_DATES table
        DATE extends UpdatableRecord<DATE>,

        // T_BOOLEANS table
        BOOL extends UpdatableRecord<BOOL>,

        // T_DIRECTORY table
        D extends UpdatableRecord<D>,

        // T_TRIGGERS table
        T extends UpdatableRecord<T>,

        // T_UNSIGNED table
        U extends TableRecord<U>,

        // T_EXOTIC_TYPES table
        UU extends UpdatableRecord<UU>,

        // T_IDENTITY table
        I extends TableRecord<I>,

        // T_IDENTITY_PK table
        IPK extends UpdatableRecord<IPK>,

        // Various tables related to trac ticket numbers
        T725 extends UpdatableRecord<T725>,
        T639 extends UpdatableRecord<T639>,
        T785 extends TableRecord<T785>,
        CASE extends UpdatableRecord<CASE>> {

This is hardly ever used for static type-checking. Yet it heavily slows down the Eclipse compiler. We should remove those generics in order for tests to be more maintainable.

This might also help implementing #682

@lukaseder
Copy link
Member Author

It doesn't seem to be related to the generics...

@lukaseder lukaseder modified the milestones: Graveyard of bad ideas, Version 3.4.0 Apr 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant