Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QualifiedName.nonEmpty() shouldn't clone argument #6640

Closed
lukaseder opened this issue Oct 5, 2017 · 0 comments
Closed

QualifiedName.nonEmpty() shouldn't clone argument #6640

lukaseder opened this issue Oct 5, 2017 · 0 comments
Labels
C: Functionality P: Low R: Fixed T: Defect
Milestone
Version 3.11.0

Comments

@lukaseder
Copy link
Member

lukaseder commented Oct 5, 2017 •
edited

This is a microoptimisation. It might impact a very small percentage in a profiled benchmark:

Before:

image

After:

image

It is safe to avoid the clone, as the array is not being modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality P: Low R: Fixed T: Defect
Projects
None yet
Milestone
Version 3.11.0
Development

No branches or pull requests
1 participant
@lukaseder