Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QualifiedName.nonEmpty() shouldn't clone argument #6640

Closed
lukaseder opened this issue Oct 5, 2017 · 0 comments

Comments

@lukaseder
Copy link
Member

commented Oct 5, 2017

This is a microoptimisation. It might impact a very small percentage in a profiled benchmark:

Before:

image

After:

image

It is safe to avoid the clone, as the array is not being modified.

@lukaseder lukaseder added this to the Version 3.11.0 milestone Oct 5, 2017

lukaseder added a commit that referenced this issue Oct 5, 2017

@lukaseder lukaseder added the R: Fixed label Oct 5, 2017

@lukaseder lukaseder closed this Oct 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.