Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPADatabase may not be able to properly detect AttributeConverter #8512

Closed
lukaseder opened this issue Apr 11, 2019 · 3 comments
Closed

JPADatabase may not be able to properly detect AttributeConverter #8512

lukaseder opened this issue Apr 11, 2019 · 3 comments
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Defect
Milestone
Version 3.12.0

Comments

@lukaseder
Copy link
Member

JPADatabase detects if JPA entities are annotated with AttributeConverter and generates a jOOQ Converter to bridge to that implementation (#6517).

This doesn't always work, depending on whether Class.getMethods() returns the interface method whose convertToEntityAttribute() method return type is Object, or the synthetic bridge method, whose convertToEntityAttribute() method return type is the user defined type.
@lukaseder lukaseder added this to the Version 3.12.0 milestone Apr 11, 2019
@lukaseder
Copy link
Member Author

The current implementation is wrong, but didn't cause the issue.

lukaseder added a commit that referenced this issue Apr 11, 2019
@lukaseder
[#8512] JPADatabase may not be able to properly detect AttributeConve…
381adbc 
…rter
@lukaseder
Copy link
Member Author

This is a regression introduced with #8446, a new feature introduced in jOOQ 3.12. No backport needed

lukaseder added a commit that referenced this issue Apr 11, 2019
@lukaseder
[#8512] JPADatabase may not be able to properly detect AttributeConve…
ab3f0ed 
…rter

Some implementation of this database may have already configured a forced type programmatically, so we must not set the list but append it.
@lukaseder lukaseder mentioned this issue Apr 11, 2019
Closed
@lukaseder
Copy link
Member Author

The implementation is not very clean but fixes the issue. A cleaner implementation will be made with #8514, which adds new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation E: All Editions P: Medium R: Fixed T: Defect
Projects
None yet
Milestone
Version 3.12.0
Development

No branches or pull requests
1 participant
@lukaseder