Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quoting built-in function calls #8813

Closed
knutwannheden opened this issue Jun 18, 2019 · 1 comment
Closed

Support quoting built-in function calls #8813

knutwannheden opened this issue Jun 18, 2019 · 1 comment

Comments

@knutwannheden
Copy link
Contributor

Most (if not all) databases have a set of built-in functions. Whether the name of a built-in function in an SQL query should be regarded as a keyword or identifier could potentially depend on the SQL dialect. But for dialects where these are identifiers, it would make sense if they would get quoted if RenderQuotedNames#ALWAYS is specified in the Settings.

@lukaseder
Copy link
Member

This change is included in #9931, when (if) we introduce a new concept of a "system name", i.e. a special kind of name for a built-in function.

I think that quoting these is almost never a good idea, even in dialects that have an actual function in the catalog backing the built-in function. There are always exceptions, and special functions that are not part of the catalog after all, but are translated by the parser to some other internal function syntax.

Closing this as a duplicate of #9931

@lukaseder lukaseder added this to To do in 3.14 Other improvements via automation Aug 10, 2020
@lukaseder lukaseder moved this from To do to Done in 3.14 Other improvements Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants