Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new DSL.systemName type #9931

Closed
lukaseder opened this issue Mar 10, 2020 · 1 comment
Closed

Add a new DSL.systemName type #9931

lukaseder opened this issue Mar 10, 2020 · 1 comment

Comments

@lukaseder
Copy link
Member

lukaseder commented Mar 10, 2020

In the course of some recent refactorings around aggregate functions (#9930), we're now changing aggregate functions to produce:

  • Quoted, qualified names when they're user defined
  • Unquoted names when they're system functions (such as COUNT(), SUM(), etc.)

It is desireable to use org.jooq.Name for this, as in that case, the RenderNameCase setting will apply. But when specifying RenderQuotedNames.ALWAYS, this will now lead to quoted aggregate functions, whose case is probably incorrect.

In order to fix this, we need a new type of org.jooq.Name, the DSL.systemName(), which is:

  • Unqualified
  • Unquoted

It never gets quoted, not even with RenderQuotedNames.ALWAYS.


See also:

@lukaseder lukaseder added this to the Version 3.14.0 milestone Mar 10, 2020
@lukaseder lukaseder added this to To do in 3.16 Other improvements via automation Dec 17, 2021
@lukaseder lukaseder changed the title Add a new DSL.systemName type and RenderQuotedNames.ALWAYS_EXCEPT_SYSTEM_NAMES Add a new DSL.systemName type Dec 17, 2021
lukaseder added a commit that referenced this issue Dec 17, 2021
This also fixes: [#12752] DDLDatabase defaultNameCase property shouldn't affect built in functions in view definitions
@lukaseder
Copy link
Member Author

Fixed in jOOQ 3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant