Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing of COUNT(DISTINCT <row-value-expression>) #9111

Closed
knutwannheden opened this issue Aug 30, 2019 · 0 comments
Closed

Allow parsing of COUNT(DISTINCT <row-value-expression>) #9111

knutwannheden opened this issue Aug 30, 2019 · 0 comments
Assignees
@knutwannheden
Labels
C: Parser E: All Editions P: Medium R: Fixed T: Defect
Projects
3.13 Other improvements
Milestone
Version 3.13.0

Comments

@knutwannheden
Copy link
Contributor

While dialects like MySQL allows expressions like COUNT(DISTINCT col1, col2) other dialects like PostgreSQL and H2 allow row value expressions like COUNT(DISTINCT (col1, col2)). Currently the parser doesn't allow parsing expressions like this.
@knutwannheden knutwannheden added this to the Version 3.13.0 milestone Aug 30, 2019
@knutwannheden knutwannheden self-assigned this Aug 30, 2019
knutwannheden added a commit that referenced this issue Aug 30, 2019
@knutwannheden
[#9111] Support parsing COUNT(DISTINCT (A, B))
a8ffd25 
Dialects like H2 and PostgreSQL allow row value expressions following
the `DISTINCT` keyword.
knutwannheden added a commit that referenced this issue Aug 30, 2019
@knutwannheden
[#9111] Support parsing COUNT(DISTINCT ROW(A, B))
eaf48e4 
In H2 a row value expression can alternatively also use the `ROW()`
syntax.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knutwannheden knutwannheden

Labels
C: Parser E: All Editions P: Medium R: Fixed T: Defect
Projects
No open projects
3.13 Other improvements
  
Done
Milestone
Version 3.13.0
Development

No branches or pull requests
1 participant
@knutwannheden