Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CREATE SEQUENCE implementation should reuse Sequence.getDataType() in various flags #9480

Closed
lukaseder opened this issue Oct 31, 2019 · 1 comment
Closed

CREATE SEQUENCE implementation should reuse Sequence.getDataType() in various flags #9480

lukaseder opened this issue Oct 31, 2019 · 1 comment
Assignees
@lukaseder
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Defect
Projects
3.13 DDL interpretation
Milestone
Version 3.13.0

Comments

@lukaseder
Copy link
Member

The CreateSequenceImpl class has method implementations like this:

    @Override
    public final CreateSequenceImpl incrementBy(Number value) {
        return incrementBy(DSL.val(value));
    }

When we really should re-use the Sequence.getDataType() in case it has converters, etc.
@lukaseder lukaseder added this to the Version 3.13.0 milestone Oct 31, 2019
@lukaseder lukaseder added this to To do in 3.13 DDL interpretation via automation Oct 31, 2019
@lukaseder lukaseder self-assigned this Oct 31, 2019
lukaseder referenced this issue Oct 31, 2019
@knutwannheden
[#9437] Add flag clauses to ALTER SEQUENCE to DSL API
b8cbde2 
Adds the new `AlterSequenceFlagsStep` as a supertype to
`AlterSequenceStep`, which allows setting and clearing various flags
like `MINVALUE` and `CACHE`.
lukaseder added a commit that referenced this issue Oct 31, 2019
@lukaseder
[#9480] CREATE SEQUENCE implementation should reuse Sequence.getDataT…
85ce843 
…ype() in various flags
@lukaseder
Copy link
Member Author

Fixed in jOOQ 3.13.0. Backport scheduled for 3.12.3 (#9481)

3.13 DDL interpretation automation moved this from To do to Done Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukaseder lukaseder

Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Defect
Projects
3.13 DDL interpretation
  
Done
Milestone
Version 3.13.0
Development

No branches or pull requests
1 participant
@lukaseder