[#9872] LiquibaseDatabase should use provided contexts on update #9874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fadelis
commented
Feb 25, 2020
| @@ -97,7 +97,8 @@ | |||
| @Override | |||
| protected void export() throws Exception { | |||
| String scripts = getProperties().getProperty("scripts"); | |||
| includeLiquibaseTables = Boolean.valueOf(getProperties().getProperty("includeLiquibaseTables", "false")); | |||
| String liquibaseContexts = getProperties().getProperty("contexts", ""); | |||
There was a problem hiding this comment.
I don't think this should be prefixed with the database. prefix as it is not a database property. But maybe it could be prefixed with something else, currently just went based on the scripts property.
There was a problem hiding this comment.
Inside of Liquibase, the Contexts object gets passed along to changeLogParameters. I'd say, we call it changeLogParameters.contexts.
|
Thanks a lot for your suggestion. I'll merge and fix according to my comments. I think we can safely backport this to 3.13.2, for immediate availability as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.